Repository navigation
wpfacts: move the promise and iteration protocol helpers out of gen_expr.rs (pure move, file size cap) - #14525
Merged
Merged
Conversation
added 3 commits
November 12, 2026 06:36
…xpr.rs (pure move, file size cap)
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/check_file_size.shfails on main forcrates/perry-wpfacts/src/gen_expr.rs: 2011 code lines against the cap of 2000, and the file is not in the allowlist. This PR does what the script asks: a small topical split, not an allowlist entry.Pure move of one function group, the promise and iteration protocol helpers of
impl Gen, into the new sibling modulegen_protocol.rs:awaited,resolver_fn,async_body,promise_of(await / promise adoption / untransformed async body)iterate,iterator_of(for-of and GetIterator)The six methods stay
pub(crate)methods ofGenwith unchanged bodies, comments and formatting; callers need no change and nothing is re-exported (they are inherent methods, not free items).lib.rsgainsmod gen_protocol;.diffof the removed lines against the added body is empty.gen_expr.rs: 2011 -> 1932 code lines;gen_protocol.rs: 83.The group was chosen because it was last edited on 2026-11-09 (three lines) and otherwise in October; the keyed-store / putvalue /
IndexSetemission that open lanes are editing is not touched.Switch: none (no behaviour change).
Checks
cargo check -p perry-wpfacts --lib --testsafter merging main b40d812: clean, no warnings.rustfmt --checkon the new file: clean.